bleachbit / bleachbit / 21789922109

76%

master: 76%

push

github

Do not report file deleted when access denied

This affected BleachBit version 5.0.2 and earlier.

When testing on Windows or Linux, run with regular permissions
(not root or admin). The target file must exist, and
the test file should have a non-zero size. The expected
test result is
(1) Shows short "Access denied" error
(2) Space recovered is 0B
(3) Deleted file count is 0

Example test on Linux.

$ python3 bleachbit.py --debug -s /var/log/auth.log.1
clean_operation('_gui'), options = '['files']'
IOError #1 shredding '/var/log/auth.log.1'
exhausted long rename: /var/log/auth.log.1
exhausted short rename: /var/log/auth.log.1
Access denied: /var/log/auth.log.1
Disk space recovered: 0B
Files deleted: 0

Example test on Windows

python bleachbit.py --debug -s c:\windows\__delete_me_test.txt
clean_operation('_gui'), options = '['files']'
IOError #13 shredding '\\?\c:\windows\__delete_me_test.txt'
exhausted long rename: \\?\c:\windows\__delete_me_test.txt
exhausted short rename: \\?\c:\windows\__delete_me_test.txt
Access denied: \\?\c:\windows\__delete_me_test.txt
Disk space recovered: 0B
Files deleted: 0
Errors: 1

Reported by rados
Closes https://github.com/bleachbit/bleachbit/issues/1157

Reported by by KMRichards
https://github.com/bleachbit/bleachbit/issues/1813

Reported by timothy-heap
https://github.com/bleachbit/bleachbit/security/advisories/GHSA-4hhr-f8wx-2v6c
https://github.com/bleachbit/bleachbit/security/advisories/GHSA-5chf-p6pj-crvw
https://github.com/bleachbit/bleachbit/issues/1996
https://github.com/bleachbit/bleachbit/issues/1995

13 of 16 new or added lines in 2 files covered. (81.25%)

6256 of 8705 relevant lines covered (71.87%)

0.72 hits per line