stacklok / toolhive / 21778470428

61%

Build Type

push

github

Committed by web-flow

Commit Message

fix(proxy): Rewrite Host header for backends with strict host validation (#3688)

* Fix Host header rewriting for backends with strict host validation

The transparent proxy was only rewriting the Host header for remote
deployments (isRemote=true), but not for Kubernetes deployments.
This caused backends with strict host validation (like Django's
ALLOWED_HOSTS or FastAPI's TrustedHostMiddleware) to reject requests
because they received the Kubernetes service DNS name as the Host
header instead of their own hostname.

The fix removes the isRemote condition so the Host header is always
rewritten to match the target URL, ensuring compatibility with strict
host validation regardless of deployment type.

Also adds an Address() method to TransparentProxy for testing purposes.

Fixes: https://github.com/stacklok/stacklok-epics/issues/231
Co-authored-by: Cursor <cursoragent@cursor.com>

* cleanup

Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>

---------

Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

Run Details

7 of 7 new or added lines in 1 file covered. (100.0%)

5 existing lines in 2 files now uncovered.

41653 of 68311 relevant lines covered (60.98%)

77.73 hits per line