systemd / systemd / 21770421410

72%

Build Type

push

github

Committed by bluca

Commit Message

daemon-util: downgrade log level on ECONNREFUSED and friends

This partially reverts 36c557f7d, which
introduced notify_remove_fd() that logs in LOG_DEBUG. However,
notify_remove_fd_warn() is still called other library functions, e.g.
notify_push_fd(), and produces warning message about the failure in
removing fd from fdstore on shutdown.

During shutdown process, we get the following logs:
```
systemd-udevd[370]: Failed to send notify message to '/run/systemd/notify': Connection refused
systemd-udevd[370]: Failed to remove file descriptor "config-serialization" from the store, ignoring: Connection refused
systemd-udevd[370]: Failed to send notify message to '/run/systemd/notify': Connection refused
systemd-udevd[370]: Failed to push serialization fd to service manager: Connection refused
```
Here, the 1st, 3rd, and 4th messages are in LOG_DEBUG, but the 2nd one
was in LOG_WARNING before this commit, and this makes it also in LOG_DEBUG.

Follow-up for 472404aca.

Run Details

2 of 2 new or added lines in 2 files covered. (100.0%)

430 existing lines in 30 files now uncovered.

311628 of 428439 relevant lines covered (72.74%)

1148312.85 hits per line