• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stacklok / toolhive / 21758345730
61%

Build:
DEFAULT BRANCH: main
Ran 06 Feb 2026 04:51PM UTC
Jobs 1
Files 507
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

06 Feb 2026 04:43PM UTC coverage: 61.109% (+0.02%) from 61.094%
21758345730

push

github

web-flow
Fix ServiceAccount secret accumulation on OpenShift (#3627)

On OpenShift/OKD, the openshift-controller-manager automatically manages
the Secrets and ImagePullSecrets fields on ServiceAccounts by creating
kubernetes.io/service-account-token and kubernetes.io/dockercfg secrets.

Previously, the operator's upsertServiceAccount function unconditionally
overwrote these fields with nil during reconciliation. This caused
OpenShift to detect the SA as "missing dockercfg" and create new secrets,
while the old ones became orphaned. Over time, this led to unbounded
secret accumulation (~90 orphaned secret pairs/day).

This fix preserves existing Secrets and ImagePullSecrets fields when the
desired values are nil, following the pattern recommended in:
https://github.com/operator-framework/operator-sdk/issues/6494

The fix is safe for standard Kubernetes clusters where these fields are
typically empty anyway.

Fixes #3622

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Don Browne <dmjb@users.noreply.github.com>

12 of 12 new or added lines in 1 file covered. (100.0%)

4 existing lines in 2 files now uncovered.

41704 of 68245 relevant lines covered (61.11%)

78.0 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
2
86.42
0.0% pkg/auth/oauth/flow.go
2
71.43
-1.68% pkg/vmcp/k8s/manager.go
Jobs
ID Job ID Ran Files Coverage
1 21758345730.1 06 Feb 2026 04:51PM UTC 507
61.11
GitHub Action Run
Source Files on build 21758345730
  • Tree
  • List 507
  • Changed 5
  • Source Changed 1
  • Coverage Changed 5
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #21758345730
  • cb013211 on github
  • Prev Build on main (#21757535216)
  • Next Build on main (#21759702117)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc