stacklok / toolhive / 21741964253

61%

Build Type

push

github

Committed by web-flow

Commit Message

fix(#3636): allow composite tools to use filtered backend tools (#3637)

* fix: allow composite tools to use filtered backend tools

Previously, using `filter` in aggregation.tools config would remove
backend tools from the routing table entirely, preventing composite
tools from calling them. This was inconsistent with `excludeAll` which
correctly kept tools in the routing table while hiding them from clients.

This fix moves Filter logic to be applied alongside ExcludeAll in
MergeCapabilities (via shouldAdvertiseTool), ensuring filtered tools
remain in the routing table for composite tool workflows.

Changes:
- Modified processBackendTools to only apply Overrides, not Filter
- Updated shouldAdvertiseTool to check Filter configuration
- Added comprehensive unit tests for Filter behavior
- Added combined E2E test with ExcludeAll and Filter on separate backends
- Updated documentation to clarify visibility vs routing semantics
- Changed terminology from "LLM" to "MCP client" for accuracy

Fixes: #3636

* -m

Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>

---------

Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>

Run Details

22 of 22 new or added lines in 2 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

41439 of 67825 relevant lines covered (61.1%)

75.64 hits per line