lucasliet / llm-telegram-bot / 21737185044

55%

Build Type

push

github

Committed by web-flow

Commit Message

fix: correct token estimation to include tool results before summarization (#23)

* fix: address code review issues from PR #22

- Fix buggy JSON.parse truthy check in readInitialStreamAndExtract
- Replace @ts-ignore with properly typed params object
- Add TSDoc to responseMap function
- Fix misleading 'parallel' TSDoc in AgentLoopExecutor
- Remove inline comment violating code style

* fix: correct token estimation to include tool results before summarization

The summarizeToolResults function was estimating tokens only from existing
messages without including the new tool results. This caused the safeguard
to fail - it would decide 'we have space' based on current messages, add
the large tool results, then exceed the context window on the next API call.

Changes:
- Add estimateToolResultsTokens() to calculate tokens from tool results
- Calculate totalTokensAfterAdding = currentTokens + toolResultsTokens
- Simplify condition: summarize when total > maxTokens
- Remove complex summarizationCost/minRequiredTokens logic

Fixes context overflow: 400 prompt token count exceeds limit of 128000

* fix: address code review issues for token estimation and add comprehensive tests

- Fix bug #1: estimate full ToolExecutionResult object instead of just result field
- Fix bug #2: add RESPONSE_BUFFER (2000 tokens) to summarization threshold
- Improve logging to show currentTokens and toolResultsTokens separately
- Add 20 comprehensive tests for AgentLoopExecutor covering:
  - Basic execution flow (4 tests)
  - Iteration limits (2 tests)
  - Tool execution (4 tests)
  - Summarization logic (5 tests) - validates bug fixes
  - Error handling (2 tests)
  - Observability callbacks (3 tests)
- Increase AgentLoopExecutor test coverage from 29.56% to 97.6%

Run Details

138 of 296 branches covered (46.62%)

Branch coverage included in aggregate %.

15 of 18 new or added lines in 2 files covered. (83.33%)

1 existing line in 1 file now uncovered.

2407 of 3671 relevant lines covered (65.57%)

19.59 hits per line