MarkUsProject / Markus / 21736117116

92%

push

github

Added ability for admins to remove instructor from course (#7808)

* TICKET-578: Add destroy action for instructors

Add the ability for administrators to remove instructors from a course.

- Add destroy route for instructors resource
- Add destroy action to InstructorsController with error handling
- Add destroy? policy rule restricted to admin users
- Add dependent declarations to Instructor model for safe deletion
  (nullify annotations, restrict on notes, destroy tags/split_pdf_logs)
- Add i18n flash messages for destroy success/error/restricted

* TICKET-578: Add remove button to instructor table for admins

- Add trash icon to instructor table, visible only to admin users
- Add removeInstructor method that sends DELETE and refreshes table
- Pass is_admin prop from view based on current_user.admin_user?

* TICKET-578: Add tests for instructor destroy

Controller specs:
- Unauthorized (non-admin) user gets 403
- Destroy failure returns bad_request with error flash
- Instructor with notes is restricted (conflict)
- Successful deletion with cascade checks (annotations nullified, tags destroyed)

Policy specs:
- End user is denied destroy access
- Admin user is allowed destroy access

Frontend specs:
- Remove button visible when is_admin is true
- Remove button hidden when is_admin is false or unset
- DELETE request sent to correct endpoint on click

* TICKET-578: Add changelog entry

* TICKET-578: Add confirmation dialog before instructor removal

* TICKET-578: Add tests for confirmation dialog

* TICKET-578: Change tags and split_pdf_logs to restrict_with_exception

935 of 1829 branches covered (51.12%)

Branch coverage included in aggregate %.

97 of 98 new or added lines in 7 files covered. (98.98%)

44727 of 47957 relevant lines covered (93.26%)

123.33 hits per line