Qiskit / qiskit / 21716415231
88%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 897
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.967% (-0.005%) from 87.972%
21716415231

push

github

web-flow 
Specify precise file dependencies in `Makefile` (#14504)

* Specify precise file dependencies in `Makefile`

This refactors the C components of the Makefile significantly to better
isolate three types of logic:

- what files actually need to be built and output
- how to build each file
- where each file should be "installed" for the output distribution

This is motivated because the `Makefile` was already missing several
include files and directories that needed to be copied over or created,
and we intend to make further changes to the C library distribution
logic in the future.

When the `include/qiskit/` distribution subdirectory was added, the rules
that construct it and the contained files were appended to existing
rules for `qiskit.h`, which meant that make did not understand the true
dependency chain, and so did not reliably consider the sources dirty
because it didn't know about them. This meant that it might not create
necessary intermediate states, and might not update changed files in a
pre-built directory.

We also remove the top-level `CMakeLists.txt` file because the top-level
of the repository doesn't actually use CMake at all; we previously only
used it to feed in the otherwise out-of-tree locations of the Qiskit
library and include files.  This moves all the CMake logic into `test/c`
as an isolated project, and has the Makefile (which is what actually
arranges for the files to exist in the first place) fill in the search
locations for them.

I used the LLM below to help remind me of GNU Make options and built-in
variables.

AI disclosure: IBM Bob 0.0.14 with claude-3-5-sonnet-20241022

* Move C coverage logic into `Makefile`

The logic of running the C test suite with coverage enabled was
duplicated between the `Makefile` and the Coverage runner, making it
harder to keep in sync.  This makes sure they'll be unified.

* Correct newly non-nested output directory

* Avoid comments within recipes

* Add `clib-dev` recipe

This allows build... (continued)

99964 of 113638 relevant lines covered (87.97%)

1159837.06 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
87.17
 0.0% crates/circuit/src/parameter/parameter_expression.rs
3
92.29
 0.77% crates/qasm2/src/lex.rs
10
72.91
 -0.41% crates/circuit/src/parameter/symbol_expr.rs
Jobs
ID Job ID Ran Files Coverage
1 21716415231.1 897
87.97
 GitHub Action Run
Source Files on build 21716415231