facebookincubator / TTPForge / 21713962013

56%

main: 67%

Pull #594

github

Reload sub-TTP after templating args to fix step-level template resolution

Summary:
When a parent TTP passes arguments to a sub-TTP using step-level templating (`{[{ .StepVars.x }]}`), and the sub-TTP uses TTP-level templating on those args (like `{{range}}` or `{{splitList}}`), the args were not being resolved before the sub-TTP was loaded and rendered.

The issue was that `SubTTPStep.Validate()` called `loadSubTTP()` which loads and renders the sub-TTP YAML before `Template()` was called to resolve the step-level templates in the args. This caused the sub-TTP's TTP-level templating to receive literal template strings like `{[{ .StepVars.x }]}` instead of resolved values.

The fix adds a call to `s.loadSubTTP(execCtx)` at the end of `SubTTPStep.Template()` to reload the sub-TTP after args are resolved.

Reviewed By: RoboticPrism

Differential Revision: D92201696

1 of 1 new or added line in 1 file covered. (100.0%)

2850 of 5071 relevant lines covered (56.2%)

14.86 hits per line