Qiskit / qiskit / 21710567018

88%

main: 88%

Build Type

push

github

Committed by web-flow

Commit Message

Fix digit escaping in OpenQASM 3 identifier (#15305) (#15650)

* Fix digit escaping in OpenQASM 3 identifier

The previous regex used `\w` as the match for an initial id character,
and `[\w\d]` for continuations.  Actually, `\w` matches any character
that `str.isalnum` returns `True` plus the underscore, which includes
all Unicode characters in the "digit" class, so is a superset of `\d`.
The match `\d` is only the Unicode group `[Nd]` (decimal digits), which
is not as complete as the entire `[N?]` set, so we can't even use
variants of `[^\W\d_]` or the like to get something usable; we'd have to
pull in the third-party `regex` package or the like to make an exact
match.

This instead causes the Qiskit exporter to allow only a subset of valid
OQ3 identifiers on export in lieu of _complete_ matching.  Additionally,
we now do not accidentally include digits in the allowed set of initial
characters for IDs (but do allow then in continuations).

* Add tests of multiple consecutive characters

* Fix broken test

(cherry picked from commit cc675b6d3)

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

13 existing lines in 3 files now uncovered.

96631 of 109385 relevant lines covered (88.34%)

1202908.72 hits per line