stacklok / toolhive / 21709772267

61%

push

github

Consolidate file locking and fix error handling in config_editor.go (#3617)

Extract a shared withFileLock() helper used by all ConfigUpdater
implementations (JSON, YAML, TOML)

Key changes:
- Rename tomlWithFileLock to withFileLock for shared use
- Refactor JSON and YAML updaters to use the shared helper
- JSON error handling: return errors instead of only logging
- Use Warnf (not Errorf) for write failures across all formats
- Added package documentation on error handling

Error propagation behavior (documented in config_editor.go):
- CLI commands (thv client register): errors are fatal, exit code 1
- Background ops (RemoveServerFromClients): errors logged as warnings
- Migrations: errors logged as warnings, migration continues

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

69 of 131 new or added lines in 1 file covered. (52.67%)

40945 of 67326 relevant lines covered (60.82%)

78.46 hits per line