visgl / deck.gl / 21682722553

91%

push

github

fix(core): Enable shader/pipeline caching for attached WebGL devices (#9971)

* fix(core): Enable shader/pipeline caching for attached WebGL devices

When attaching to an external WebGL context (e.g., MapboxOverlay with
interleaved: true), the caching props were not being set, unlike the
_createDevice() path which explicitly enables them.

This caused severe performance degradation in interleaved mode because
luma.gl's PipelineFactory would create new shader pipelines every frame
instead of reusing cached ones.

The fix adds _cacheShaders: true and _cachePipelines: true to the
webgl2Adapter.attach() call, matching the defaults set in _createDevice().
User-provided deviceProps can still override these if needed.

Fixes #9839
Related: #9822, luma.gl#2465

* Caching props moved below default deviceProps, to ensure caching always applies.

Co-authored-by: chrisgervang <chrisgervang@users.noreply.github.com>

* Changes reverted:
- Caching is enabled by default
- User is able to override default cache-settings via deviceProps should they need.

---------

Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com>

6863 of 7542 branches covered (91.0%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

56823 of 62373 relevant lines covered (91.1%)

14385.21 hits per line