stacklok / toolhive / 21680231196

61%

Build Type

push

github

Committed by web-flow

Commit Message

Fix zombie process when proxy stops due to health check failure (#3543)

When health checks fail for a remote MCP server, the TransparentProxy
calls Stop() which closes its shutdownCh. However, HTTPTransport.IsRunning()
only checked its own shutdownCh, not the proxy's. This caused the runner's
status monitor to keep returning true, preventing the process from exiting.

Changes:
- Add IsRunning() method to the Proxy interface
- Update HTTPTransport.IsRunning() to also check proxy.IsRunning()
- Add IsRunning() implementations to HTTPSSEProxy and HTTPProxy (streamable)
- Add unit tests for the IsRunning behavior
- Add e2e test for health check zombie prevention

The TransparentProxy already had IsRunning() - this change ensures the
HTTPTransport properly delegates to it when checking running status.

Signed-off-by: Greg Katz <gkatz@indeed.com>
Co-authored-by: Don Browne <dmjb@users.noreply.github.com>

Run Details

28 of 49 new or added lines in 7 files covered. (57.14%)

2 existing lines in 1 file now uncovered.

40314 of 66400 relevant lines covered (60.71%)

75.96 hits per line