supabase / wrappers / 21668712743

76%

Build Type

push

github

Committed by web-flow

Commit Message

fix: serialize data instead of pointer in plan_foreign_modify (#548)

* fix: serialize data instead of pointer in plan_foreign_modify

Fix PostgreSQL server crash when using prepared statements with foreign
tables. PostgreSQL caches query plans after ~5-6 executions. The previous
implementation stored a raw pointer to FdwModifyState in fdw_private,
which became invalid after end_foreign_modify freed the state.

Solution:
- Add FdwModifyPrivate struct holding serializable reconstruction data
- Serialize table OID, rowid info (not pointer) in plan_foreign_modify
- Create fresh FdwModifyState in begin_foreign_modify for each execution

Also includes stress test for issue #482 that executes 15 parameterized
INSERT operations to validate the fix.

Fixes #482
Related to #237

* fix: serialize data instead of pointer in plan_foreign_modify

Fixes PostgreSQL server crash when using prepared statements with
foreign tables (issue #482).

The root cause was that PostgreSQL caches query plans after ~5-6
executions (generic plan optimization). The previous implementation
stored a raw pointer to FdwModifyState in fdw_private, which became
invalid after end_foreign_modify freed the state. Subsequent executions
with cached plans dereferenced this stale pointer, causing a crash.

Solution:
- Add FdwModifyPrivate struct holding serializable reconstruction data
- Serialize table OID, rowid info (not pointer) in plan_foreign_modify
- Create fresh FdwModifyState in begin_foreign_modify for each execution

This ensures each query execution gets a valid FDW instance and state,
even when PostgreSQL reuses a cached query plan and skips planning.

* test(clickhouse): add prepared statement stress test

Validates fix for issue #482 by executing 15 parameterized INSERT
operations - enough to trigger PostgreSQL's generic plan caching.
Before the fix, this would crash around iteration 7.

* fix(clippy): inline format args in stress test

Fix uninlined-format-args clippy warning by... (continued)

Run Details

76 of 80 new or added lines in 1 file covered. (95.0%)

1 existing line in 1 file now uncovered.

6776 of 8899 relevant lines covered (76.14%)

53.0 hits per line