stacklok / toolhive / 21667999079

61%

Build Type

push

github

Committed by web-flow

Commit Message

Add CLI validation for Desktop app alignment (#3535)

* feat(cli): add desktop alignment validation package

Add pkg/desktop/ package to detect and validate when ToolHive Desktop
manages CLI installation via marker file at ~/.toolhive/.cli-source.

- types.go: CliSourceMarker and ValidationResult structs
- marker.go: marker file reading and path utilities
- validation.go: path comparison and conflict detection logic

Related to: toolhive-studio#1512
RFC: THV-0020

* feat(cli): integrate desktop validation into root command

Add PersistentPreRunE hook to validate desktop alignment before
every CLI command. Returns hard stop error when conflict detected
between standalone CLI and Desktop-managed installation.

* test(cli): add desktop validation unit and e2e tests

- Unit tests for marker file parsing, path comparison, symlink resolution
- E2E tests for conflict scenarios, stale markers, and skip override

* fix(cli): address linter errors in desktop validation

- Simplify if-return in commands.go (revive)
- Add gosec nolint for marker file read (G304)
- Add paralleltest nolint for tests that modify HOME env
- Add goconst nolint for platform checks
- Fix gci import ordering and struct formatting

* test(cli): improve desktop validation test coverage

Add additional unit tests to improve coverage from ~70% to ~87%:
- Test MarkerFileExists() function
- Test ReadMarkerFile() function
- Test GetMarkerFilePath() function
- Test ValidateDesktopAlignment() with actual conflict
- Test CheckDesktopAlignment() with copy method
- Test buildConflictMessage() without desktop version
- Test ReadMarkerFileFromPath() with read error
- Test resolvePath() with relative paths
- Test pathsEqual() on both case-sensitive and case-insensitive platforms

Remaining uncovered lines are OS error paths that require mocking.

* fix(cli): add paralleltest nolint to test functions

* fix(windows): add logic for copy on windows

* refactor: adress feedback

Run Details

142 of 185 new or added lines in 3 files covered. (76.76%)

3 existing lines in 2 files now uncovered.

40288 of 66337 relevant lines covered (60.73%)

75.83 hits per line