BehaviorTree / BehaviorTree.CPP / 21666718139

80%

Build Type

push

github

Committed by web-flow

Commit Message

Fix #953: getInput() now uses stored converter for plugin custom types (#1104)

When a node is loaded as a plugin, the convertFromString<T> specialization
defined in the plugin is not visible to the main application. This caused
getInput<T>() to fail when the custom type's converter was only in the plugin.

The fix modifies TreeNode::getInputStamped() to use the StringConverter
stored in PortInfo (captured when InputPort<T>() was called in the plugin)
rather than directly calling convertFromString<T>().

Changes:
- tree_node.h: Add parseStringWithConverter lambda that checks for stored
  converter before falling back to convertFromString<T>()
- Add plugin test (plugin_issue953.so) with custom type and converter
  defined ONLY in the plugin
- Add gtest_plugin_issue953.cpp with 3 test cases:
  - GetInputUsesStoredConverter: XML literal value
  - GetInputFromBlackboardString: Value from Script node
  - GetInputViaSubtreeRemapping: SubTree port remapping

All 447 tests pass.

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Run Details

10 of 10 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

4256 of 5459 relevant lines covered (77.96%)

24109.14 hits per line