sebnitu / vrembem / 21657579915

94%

main: 100%

push

github

Refactor and add documentation for base component (#2646)

This PR refactors the base component and fixes various bugs/issues related to CSS variable implementations. As part of this update, documentation has also been added for the base component. These include:

- Base headings now have their values set in `$type-selectors` so that they can properly apply type selectors instead of needing to duplicate styles in the type module itself.
- Base `heading-level` mixin has been removed in favor of applying the styles directly in the headings module. Since type no longer needs to also apply heading styles, the mixin no longer was needed.
- Base `selector` no accepts maps and lists for creating chained selectors. This is used in `headings` module to style all headings from `h1` to `h6`.
- Modules that used `color` CSS variables have been renamed to `foreground` to be more consistent with how Vrembem sets background and foreground values.
- Removed redundant base Sass variables in favor of setting fallbacks directly. This is to favor CSS variable overrides over using Sass vars for customization. 
- Removed no longer needed styles from `normalize` module.
- No longer setting a custom font-size and line-height to the `type` module. Fallback values are now `inherit`.
- Updated the import order of base modules in order of priority.

**Additional changes**
- `ReferenceBar` - Now takes option hash and selector props. Type is now optional as well.
- `ReferenceCard` - Now takes an optional fallback prop. Markup has been refactored for simplicity.
- `ReferenceTable` - Now has the ability to link to references in core CSS var documentation. Now also accepts links with filter events to auto fill the filter input.
- `--vb-font-size` - Default value changed from `16px` to `1rem`.
- `card_reference` - Added as new card modifier.
- Added global `scroll-margin-top` property to all children of `.layout__content`.
- Reference table styles have been improved.
- Fixed drawer an... (continued)

577 of 634 branches covered (91.01%)

Branch coverage included in aggregate %.

925 of 970 relevant lines covered (95.36%)

32.08 hits per line