Alan-Jowett / CoPilot-For-Consensus / 21656314354

78%

push

github

fix(azure): remove partition_key from replace_item() call (#1122)

* fix(azure): remove partition_key from replace_item() call

azure-cosmos 4.9.0's replace_item() does NOT have a partition_key parameter,
unlike read_item() and delete_item(). Passing partition_key causes it to
leak through **kwargs to Session.request(), raising:
'TypeError: Session.request() got an unexpected keyword argument partition_key'

The SDK infers the partition key from the document body's 'id' field, so we
simply remove the partition_key parameter from the call.

Fixes embedding service failures in Azure deployments.

Signed-off-by: Alan Jowett <alanjo@microsoft.com>

* fix: enable test_update_document on emulator - it passes with the fix

The test was incorrectly skipped because we thought the emulator had a
compatibility issue with replace_item. Actually, the issue was our bug:
passing partition_key to replace_item() which doesn't support it.

With the fix from this PR, the test passes on both emulator and real Cosmos DB.
All 17 integration tests now pass.

Signed-off-by: Alan Jowett <alanjo@microsoft.com>

* fix: address PR review comments

1. Updated troubleshooting doc to reflect correct root cause (API inconsistency,
   not version-specific regression)
2. Removed unnecessary azure-cosmos <4.14.0 version constraint from setup.py
   since the actual fix is removing partition_key from replace_item()
3. Updated history, prevention, and timeline sections to be accurate

Signed-off-by: Alan Jowett <alanjo@microsoft.com>

---------

Signed-off-by: Alan Jowett <alanjo@microsoft.com>

1 of 1 new or added line in 1 file covered. (100.0%)

8755 of 11246 relevant lines covered (77.85%)

0.87 hits per line