WashU-Astroparticle-Lab / straxion / 21654066032

64%

push

github

Use DxHits.calculate_hit_threshold to calculate spike threshold (#81)

* Use DxHits.calculate_hit_threshold, remove helper

Import DxHits and replace the local calculate_spike_threshold helper with a call to DxHits.calculate_hit_threshold to centralize hit-threshold logic. Remove the now-unused calculate_spike_threshold method and update the docstring reference from hit_threshold_dx to spike_threshold_dx. These changes avoid duplicated threshold computation and rely on the canonical implementation in .hits.

* Raise default spike_thresholds_sigma to 4.0

Update the default spike_thresholds_sigma option in straxion/plugins/hit_classification.py from 3.0 to 4.0 (for 41 entries). This increases the sigma threshold used for spike detection in hit classification, reducing sensitivity to small fluctuations and likely lowering false positive spike detections.

* Use DxHits.calculate_hit_threshold in tests

Update hit classification test to use DxHits.calculate_hit_threshold (imported from straxion.plugins.hits) instead of DxHitClassification.calculate_spike_threshold. Adjust expected threshold calculation to match the implementation's robust std estimator ((p84 - p16) / 2) rather than numpy.std, and update corresponding comments. This aligns the test with the production implementation of hit thresholding.

* Bump hit_classification plugin version to 0.3.3

Update DxHitClassification __version__ from 0.3.2 to 0.3.3 in straxion/plugins/hit_classification.py to reflect a new release. No other functional changes were made.

3 of 3 new or added lines in 1 file covered. (100.0%)

1222 of 1906 relevant lines covered (64.11%)

0.64 hits per line