thewca / worldcubeassociation.org / 21625353422

77%

push

github

Add locked_by and quit_by columns to live_results (#13297)

* add quit by and locked_by column

* add quit_competitor route

* refactor and use open_and_lock_previous

* move mark_as_quit to its own method

* don't recompute locked results

* add to factories

* fix locked_by where queries

* we do actually want to recompute pos even when locked

* add tests

* add a quit_from_round! method

* add quit after locking test

* make test more clear and add a second test

* rubocop

* naming changes

* actually check for is_quit

* fix trigger_recompute_columns

* delete a quit result instead

* don't assume that linked_rounds are always 1 + 2

* rails doesn't actually give you the locked_by_id? method

* make a first_round? method

* don't double lock

* use count directly

* return both opened_rows and locked_rows

* use transaction for now

30 of 43 new or added lines in 3 files covered. (69.77%)

9928 of 12958 relevant lines covered (76.62%)

3456.29 hits per line