graphprotocol / indexer-rs / 21598084083

69%

push

github

Fix TapReceipt type mismatch in allocation middleware (#919)

* fix: use TapReceipt type in allocation middleware

The allocation middleware was looking for `SignedReceipt` (V1 inner type)
in request extensions, but `receipt_middleware` inserts `TapReceipt` (enum).
This TypeId mismatch caused the lookup to always fail, falling back to
the `deployment_to_allocation` map which returns an arbitrary allocation.

When multiple allocations exist for the same deployment, this could cause:
- Attestations signed with wrong allocation's derived key
- Gateway verification failures ("bad attestation" errors)
- Incorrect metrics attribution

* test(service): add unit tests for allocation middleware V2 receipt handling

- Add test for extracting allocation ID from TapReceipt V2
- Add test for fallback to DeploymentId when no receipt present
- Add test for graceful handling without receipt or deployment ID
- Add test for unknown deployment IDs not in mapping

* ci: make clippy and format happy

Signed-off-by: Natanael Mojica <neithanmo@gmail.com>

---------

Signed-off-by: Natanael Mojica <neithanmo@gmail.com>

103 of 107 new or added lines in 1 file covered. (96.26%)

10476 of 15265 relevant lines covered (68.63%)

81.15 hits per line