kubeovn / kube-ovn / 21585158152

23%

Build Type

push

github

Committed by web-flow

Commit Message

Fix qos not work (#6231)

* fix(qos): fix NAT Gateway QoS not working
* fix eip deletion not trigger qos again

This PR fixes multiple issues with NAT Gateway QoS functionality:

1. Fix matchall filter handle extraction regex
   - matchall filter uses 'handle 0xNNNN' format, not 'fh' like u32 filters
   - Changed regex from 'fh [0-9a-f:]+' to 'handle 0x[0-9a-fA-F]+'

2. Fix matchall filter line extraction when u32 filters exist
   - When both u32 and matchall filters exist, 'grep -B2 matchall' captured wrong lines
   - Use 'grep matchall.*flowid' to directly match the correct line

3. Use IFB + HTB instead of police for ingress QoS
   - police drops packets exceeding rate limit (unfriendly to TCP)
   - HTB queues packets and applies backpressure, allowing TCP to adapt smoothly
   - This results in actual throughput close to the configured rate limit

4. Support decimal values for rateMax/burstMax (e.g., 1.5 Mbit/s)
   - Convert burst from MB to bytes to avoid tc parsing issues

5. Add detailed parameter documentation for all QoS functions
   - qos_add: 9 parameters
   - qos_del: 7 parameters
   - eip_*_qos_add: 4 parameters
   - eip_*_qos_del: 1 parameter

6. Add DEBUG switch for QoS troubleshooting



---------

Signed-off-by: zbb88888 <jmdxjsjgcxy@gmail.com>

Run Details

42 of 113 new or added lines in 3 files covered. (37.17%)

2 existing lines in 2 files now uncovered.

12411 of 53860 relevant lines covered (23.04%)

0.27 hits per line