542
74%

Ran 06 Sep 2016 11:00AM UTC

Jobs 1

Files 85

Run time 5s

Badge

Embed ▾

pending completion

Build # 542

Build Type

Pull #97

travis-ci

Committed by

web-flow

Commit Message

Improve static and const correctness.

- Any non-externally-visible declarations should be `static`.
- Casting away the `const` qualifier from pointers-to-const is
  dangerous. All but one instance of this are now correct. The one
  instance where we can't keep `const` is one where toxav code actually
  writes to a chunk of memory marked as `const`. This code also assumes
  4 byte alignment of data packets. I don't know whether that is a valid
  assumption, but it's likely unportable, and *not* obviously correct.
- Replaced empty parameter lists with `(void)` to avoid passing
  parameters to it. Empty parameter lists are old style declarations for
  unknown number and type of arguments.
- Commented out (as `#if DHT_HARDENING` block) the hardening code that
  was never executed.
- Minor style fix: don't use `default` in enum-switches unless the number
  of enumerators in the default case is very large. In this case, it was
  2, so we want to list them both explicitly to be warned about missing
  one if we add one in the future.
- Removed the only two function declarations from nTox.h and put them
  into nTox.c. They are not used outside and nTox is not a library.

Pull Request Pull Request #97: Improve static and const correctness.

Run Details

8539 of 11712 relevant lines covered (72.91%)

773810.46 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	83.87	0.0%	toxcore/onion.c
1	84.85	-0.76%	toxcore/ping.c
1	85.93	2.33%	toxcore/net_crypto.c
1	89.47	-0.14%	toxcore/onion_client.c
1	79.49	0.58%	toxcore/Messenger.c
10	67.08	-0.24%	toxav/toxav.c
21	65.19	0.19%	toxav/msi.c
71	77.44	3.2%	toxcore/DHT.c

Jobs

ID	Job ID	Ran	Files	Coverage
2	542.2 (BUILD=toxcore ENV=linux)	06 Sep 2016 11:00AM UTC	85	72.91	Travis Job 542.2

Source Files on build 542

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

TokTok / toxcore / 542
74%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 542

TokTok / toxcore / 542 74%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 542

TokTok / toxcore / 542
74%

README BADGES
x