535
74%

Ran 06 Sep 2016 10:08AM UTC

Jobs 1

Files 85

Run time 5s

Badge

Embed ▾

pending completion

Build # 535

Build Type

Pull #96

travis-ci

Committed by

web-flow

Commit Message

Improve C standard compliance.

- Don't cast between object and function pointers.
- Use standard compliant `__VA_ARGS__` in macros.
- Add explicit `__extension__` on unnamed union in struct (it's a GNU
  extension).
- Remove ; after function definitions.
- Replace `const T foo = 3;` for integral types `T` with `enum { foo = 3 };`.
  Folding integral constants like that as compile time constants is a GNU
  extension. Arrays allocated with `foo` as dimension are VLAs on strictly
  compliant C99 compilers.
- Replace empty initialiser list `{}` with zero-initialiser-list `{0}`.
  The former is a GNU extension meaning the latter.
- Cast `T*` (where `T != void`) to `void *` in format arguments. While any
  object pointer can be implicitly converted to and from `void *`, this
  conversion does not happen in variadic function calls.
- Replace arithmetic on `void *` with arithmetic on `char *`. The former
  is non-compliant.
- Replace non-`int`-derived types (like `uint16_t`, which is
  `short`-derived) in bit fields with `int`-derived types. Using any type
  other than `int` or `unsigned int` (or any of their aliases) in bit
  fields is a GNU extension.

Pull Request Pull Request #96: Improve C standard compliance.

Run Details

0 of 6381 relevant lines covered (0.0%)

0.0 hits per line

Uncovered Existing Lines

Lines	Coverage	File
3	100.0	toxcore/logger.c
31	100.0	toxcore/friend_requests.c
47	100.0	toxcore/ping_array.c
56	100.0	toxcore/util.c
66	100.0	toxcore/list.c
77	100.0	toxcore/crypto_core.c
80	100.0	toxcore/LAN_discovery.c
101	100.0	toxcore/ping.c
149	100.0	toxcore/onion_announce.c
230	100.0	toxcore/network.c
231	100.0	toxcore/TCP_client.c
238	100.0	toxcore/onion.c
269	100.0	toxcore/assoc.c
298	100.0	toxcore/friend_connection.c
335	100.0	toxcore/TCP_server.c
363	100.0	toxcore/TCP_connection.c
556	100.0	toxcore/onion_client.c
759	100.0	toxcore/DHT.c
963	100.0	toxcore/net_crypto.c

Jobs

ID	Job ID	Ran	Files	Coverage
2	535.2 (BUILD=toxcore ENV=linux)	06 Sep 2016 10:08AM UTC	0	0.0	Travis Job 535.2

Source Files on build 535

Detailed source file information is not available for this build.

TokTok / toxcore / 535
74%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 535

TokTok / toxcore / 535 74%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 535

TokTok / toxcore / 535
74%

README BADGES
x