21552830208

Committed 31 Jan 2026 11:40PM UTC coverage: 80.277% (-0.05%) from 80.324%

Build # 21552830208

Build Type

Pull #23062

github

Committed by

web-flow

Commit Message

Merge 808a9786c into 2c4dcf9cf

Pull Request Pull Request #23062: Remove support for Get

Run Details

18 of 25 new or added lines in 4 files covered. (72.0%)

17119 existing lines in 541 files now uncovered.

78278 of 97510 relevant lines covered (80.28%)

3.36 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

91.67

/src/python/pants/backend/nfpm/fields/scripts.py

# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from __future__ import annotations

import os
from typing import ClassVar

from pants.engine.internals.native_engine import Address
from pants.engine.target import AsyncFieldMixin, DictStringToStringField, InvalidFieldException
from pants.util.frozendict import FrozenDict


class NfpmPackageScriptsField(AsyncFieldMixin, DictStringToStringField):
    nfpm_alias = ""  # maps to more than one nfpm.yaml field
    alias: ClassVar[str] = "scripts"
    # The keys of nfpm_aliases are the only valid keys of this field.
    nfpm_aliases: ClassVar[FrozenDict[str, str]] = FrozenDict(
        {
            # The general scripts common to all packager types
            "preinstall": "scripts.preinstall",
            "postinstall": "scripts.postinstall",
            "preremove": "scripts.preremove",
            "postremove": "scripts.postremove",
        }
    )

    @classmethod
    def compute_value(
        cls, raw_value: dict[str, str] | None, address: Address
    ) -> FrozenDict[str, str] | None:
        value_or_default = super().compute_value(raw_value, address)
        if value_or_default:
            invalid_keys = value_or_default.keys() - cls.nfpm_aliases.keys()
            if invalid_keys:
                raise InvalidFieldException(
                    f"Each key for the '{cls.alias}' field in target {address} must be one of"
                    f"{repr(tuple(cls.nfpm_aliases.keys()))}, but {repr(invalid_keys)} was provided.",
                )
        return value_or_default

    @property
    def normalized_value(self) -> FrozenDict[str, str]:
        value = self.value
        if not value:
            return FrozenDict()
        return FrozenDict(
            {
                script_type: os.path.join(self.address.spec_path, script_src)
                for script_type, script_src in value.items()
            }
        )

1	# Copyright 2023 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
3
4	from __future__ import annotations	9✔
5
6	import os	9✔
7	from typing import ClassVar	9✔
8
9	from pants.engine.internals.native_engine import Address	9✔
10	from pants.engine.target import AsyncFieldMixin, DictStringToStringField, InvalidFieldException	9✔
11	from pants.util.frozendict import FrozenDict	9✔
12
13
14	class NfpmPackageScriptsField(AsyncFieldMixin, DictStringToStringField):	9✔
15	nfpm_alias = "" # maps to more than one nfpm.yaml field	9✔
16	alias: ClassVar[str] = "scripts"	9✔
17	# The keys of nfpm_aliases are the only valid keys of this field.
18	nfpm_aliases: ClassVar[FrozenDict[str, str]] = FrozenDict(	9✔
19	{
20	# The general scripts common to all packager types
21	"preinstall": "scripts.preinstall",
22	"postinstall": "scripts.postinstall",
23	"preremove": "scripts.preremove",
24	"postremove": "scripts.postremove",
25	}
26	)
27
28	@classmethod	9✔
29	def compute_value(	9✔
30	cls, raw_value: dict[str, str] \| None, address: Address
31	) -> FrozenDict[str, str] \| None:
UNCOV 32	value_or_default = super().compute_value(raw_value, address)	2✔
UNCOV 33	if value_or_default:	2✔
UNCOV 34	invalid_keys = value_or_default.keys() - cls.nfpm_aliases.keys()	1✔
UNCOV 35	if invalid_keys:	1✔
36	raise InvalidFieldException(	×
37	f"Each key for the '{cls.alias}' field in target {address} must be one of"
38	f"{repr(tuple(cls.nfpm_aliases.keys()))}, but {repr(invalid_keys)} was provided.",
39	)
UNCOV 40	return value_or_default	2✔
41
42	@property	9✔
43	def normalized_value(self) -> FrozenDict[str, str]:	9✔
UNCOV 44	value = self.value	1✔
UNCOV 45	if not value:	1✔
46	return FrozenDict()	×
UNCOV 47	return FrozenDict(	1✔
48	{
49	script_type: os.path.join(self.address.spec_path, script_src)
50	for script_type, script_src in value.items()
51	}
52	)

pantsbuild / pants / 21552830208

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous