• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

pantsbuild / pants / 21552830208

31 Jan 2026 11:40PM UTC coverage: 80.277% (-0.05%) from 80.324%
21552830208

Pull #23062

github

web-flow
Merge 808a9786c into 2c4dcf9cf
Pull Request #23062: Remove support for Get

18 of 25 new or added lines in 4 files covered. (72.0%)

17119 existing lines in 541 files now uncovered.

78278 of 97510 relevant lines covered (80.28%)

3.36 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

64.52
/src/python/pants/backend/codegen/thrift/apache/python/python_thrift_module_mapper.py
1
# Copyright 2022 Pants project contributors (see CONTRIBUTORS.md).
2
# Licensed under the Apache License, Version 2.0 (see LICENSE).
3

UNCOV
4
from __future__ import annotations
1✔
5

UNCOV
6
from collections import defaultdict
1✔
UNCOV
7
from pathlib import PurePath
1✔
UNCOV
8
from typing import DefaultDict
1✔
9

UNCOV
10
from pants.backend.codegen.thrift import thrift_parser
1✔
UNCOV
11
from pants.backend.codegen.thrift.target_types import AllThriftTargets, ThriftSourceField
1✔
UNCOV
12
from pants.backend.codegen.thrift.thrift_parser import ParsedThriftRequest, parse_thrift_file
1✔
UNCOV
13
from pants.backend.python.dependency_inference.module_mapper import (
1✔
14
    FirstPartyPythonMappingImpl,
15
    FirstPartyPythonMappingImplMarker,
16
    ModuleProvider,
17
    ModuleProviderType,
18
    ResolveName,
19
)
UNCOV
20
from pants.backend.python.subsystems.setup import PythonSetup
1✔
UNCOV
21
from pants.backend.python.target_types import PythonResolveField
1✔
UNCOV
22
from pants.engine.rules import collect_rules, concurrently, rule
1✔
UNCOV
23
from pants.engine.unions import UnionRule
1✔
UNCOV
24
from pants.util.logging import LogLevel
1✔
25

26

UNCOV
27
def thrift_path_to_py_modules(source_path: str, *, namespace: str | None) -> tuple[str, str]:
1✔
28
    prefix = namespace if namespace else PurePath(source_path).stem
×
29
    return f"{prefix}.ttypes", f"{prefix}.constants"
×
30

31

UNCOV
32
class PythonThriftMappingMarker(FirstPartyPythonMappingImplMarker):
1✔
UNCOV
33
    pass
1✔
34

35

UNCOV
36
@rule(desc="Creating map of Thrift targets to generated Python modules", level=LogLevel.DEBUG)
1✔
UNCOV
37
async def map_thrift_to_python_modules(
1✔
38
    thrift_targets: AllThriftTargets,
39
    python_setup: PythonSetup,
40
    _: PythonThriftMappingMarker,
41
) -> FirstPartyPythonMappingImpl:
42
    parsed_files = await concurrently(
×
43
        parse_thrift_file(ParsedThriftRequest(tgt[ThriftSourceField])) for tgt in thrift_targets
44
    )
45

46
    resolves_to_modules_to_providers: DefaultDict[
×
47
        ResolveName, DefaultDict[str, list[ModuleProvider]]
48
    ] = defaultdict(lambda: defaultdict(list))
49
    for tgt, parsed in zip(thrift_targets, parsed_files):
×
50
        resolve = tgt[PythonResolveField].normalized_value(python_setup)
×
51
        provider = ModuleProvider(tgt.address, ModuleProviderType.IMPL)
×
52
        m1, m2 = thrift_path_to_py_modules(
×
53
            source_path=tgt[ThriftSourceField].file_path, namespace=parsed.namespaces.get("py")
54
        )
55
        resolves_to_modules_to_providers[resolve][m1].append(provider)
×
56
        resolves_to_modules_to_providers[resolve][m2].append(provider)
×
57

58
    return FirstPartyPythonMappingImpl.create(resolves_to_modules_to_providers)
×
59

60

UNCOV
61
def rules():
1✔
UNCOV
62
    return (
1✔
63
        *collect_rules(),
64
        *thrift_parser.rules(),
65
        UnionRule(FirstPartyPythonMappingImplMarker, PythonThriftMappingMarker),
66
    )
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc