medplum / medplum / 21532276268

92%

main: 92%

push

github

Remove alignment testing from $book (#8331)

There are some edge cases that we haven't handled yet, most notably
when the alignmentInterval is set to a value greater than `60`. I had
assumed that this was invalid during initial implementation, but it has
come out that some users would like scheduling to follow a "tip to tail"
model. This works well when the slots are less than an hour and have a
length that is a divisor of 60, but otherwise was failing.

For example, consider 90 minute slots from 9am - 5pm. The desired result
from $find would be:
- 9am
- 10:30am
- 12pm
- 1:30pm
- 3pm

Right now, $find operates by getting the first aligned time, and then
generating slots by adding `alignmentInterval` minutes at a time. So
it's fairly close to this model already (the first slot _might_ not be
returned depending on the timing). But trying to feed these resulting
slots into $book could cause an error if the alignment math didn't work
out.

For now, we are opting to remove the alignment checks from $book
entirely. This means that it is possible for someone to schedule an
off-grid appointment, but it also means that all results from $find
should be accepted by $book.

We will revisit this and tighten it up later.

Signed-off-by: Noah Silas <noah@medplum.com>

16921 of 19183 branches covered (88.21%)

Branch coverage included in aggregate %.

30946 of 32681 relevant lines covered (94.69%)

13861.48 hits per line