NVIDIA / skyhook / 21528317219

81%

push

github

fix!: make imagePullSecret optional to prevent kubelet errors

BREAKING CHANGE: imagePullSecret now defaults to empty string instead
of "node-init-secret"

Previously, imagePullSecret defaulted to "node-init-secret" which
caused kubelet to log errors when the secret didn't exist. This change
makes the secret truly optional:

- chart/values.yaml: Change default from "node-init-secret" to ""
- chart/templates/deployment.yaml: Only add imagePullSecrets when set
- operator/internal/controller/skyhook_controller.go: Remove default
  value and conditionally add ImagePullSecrets to pods
- operator/config/manager/manager.yaml: Remove hardcoded secret
- Update documentation with migration instructions

Users pulling from private registries must now explicitly set
imagePullSecret in their Helm values. Users with public images
(default ghcr.io) need no changes.

2 of 14 new or added lines in 1 file covered. (14.29%)

6589 of 8141 relevant lines covered (80.94%)

4.33 hits per line