stacklok / toolhive-studio / 21517519615

53%

push

github

feat(remote-mcp): add none to authentication type for remote mcp (#1534)

* feat(remote-mcp): add DynamicClientRegistration auth type constant

Add new auth type 'dynamic_client_registration' to REMOTE_MCP_AUTH_TYPES
and its corresponding zod schema enum for remote MCP server authentication.

* feat(remote-mcp): update auth field detection and validation for DynamicClientRegistration

- Add DynamicClientRegistration detection in getRemoteAuthFieldType based on callback_port
- Move callback_port requirement from 'none' to 'dynamic_client_registration' auth type
- Update AUTH_FIELD_MATRIX to show callback_port only for dynamic_client_registration
- 'none' auth type now shows no authentication fields

* feat(remote-mcp): update default auth type to DynamicClientRegistration

- Change default auth_type from 'none' to 'dynamic_client_registration' in remote MCP forms
- Update buildAuthSecret to recognize DynamicClientRegistration as default auth type
- Add separate 'None' option in auth type selector dropdown
- DynamicClientRegistration now shows only callback_port field

* test(remote-mcp): update tests for DynamicClientRegistration auth type

- Add test suite for 'dynamic_client_registration' auth type validation
- Update 'none' auth type tests: callback_port is no longer required
- Add tests for form submission with DynamicClientRegistration (callback_port only)
- Add tests for form submission with None auth type (no auth fields)
- Update OIDC test to be standalone instead of parameterized with DCR

* leftover

* leftover

* test(remote-mcp): add tests for getRemoteAuthFieldType function

Add comprehensive test coverage for auth type detection logic:
- Returns correct auth type for each field (bearer_token, authorize_url, issuer, callback_port)
- Verifies priority order: BearerToken > OAuth2 > OIDC > DynamicClientRegistration > None
- Ensures callback_port alone returns DynamicClientRegistration
- Ensures callback_port with other fields returns the more... (continued)

2150 of 4204 branches covered (51.14%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 4 files covered. (100.0%)

3355 of 6109 relevant lines covered (54.92%)

129.59 hits per line