Alan-Jowett / CoPilot-For-Consensus / 21494422000

78%

push

github

Fix AzureServiceBusSubscriber handler shutdown recovery loop (#1076)

* Initial plan

* Add handler shutdown recovery with exponential backoff and rate-limited logging

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix linting issues (whitespace and line length)

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Address code review feedback: improve error detection, fix log message, reset retry count on success

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix critical bug: handle failed reconnection and clear client state properly

- Add check at loop start to handle None client after failed reconnection
- Set self.client = None after closing to ensure clean state
- Add explanatory comments to empty except clauses in tests
- Fix line length linting issue

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Refactor: extract reconnection logic, add thread safety, improve test reliability

- Extract duplicate reconnection logic into _attempt_reconnection_with_backoff() helper
- Add threading.Lock to protect rate limiting state (fixes concurrency issue)
- Cap retry_count at max_retries to maintain consistent max backoff
- Simplify None client handling (remove unnecessary try-except wrapper)
- Document single-threaded expectation in start_consuming() docstring
- Replace fixed sleep with polling in tests for better reliability
- All 39 tests pass

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix CI failures: linting issues and pyright type errors

- Fix whitespace and line-too-long errors in azureservicebuspublisher.py
- Fix whitespace in test files
- Remove unused mock_credentials variable
- Remove unused patch import
- Add assertion in _consume_with_receiver for ServiceBusReceiveMode to satisfy pyright
- All tests pass (39 Azure Service Bus tests)

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@u... (continued)

54 of 67 new or added lines in 1 file covered. (80.6%)

8755 of 11246 relevant lines covered (77.85%)

0.87 hits per line