gnosisguild / zodiac-modifier-roles / 21475933378

93%

main: 96%

Pull #393

github

Operator Zip (#438)

* Add ZipSome and ZipEvery operators for multi-array iteration

* ConditionLogic: consolidate zip handlers, extract _pluck

* Simplify _zipIterator and _pluckedArrayLocations

* Reorder ConditionLogic handlers for better grouping

* Fix ZipSome/ZipEvery to validate all pluck indices in compValue

* Refactor _pluckedArrayLocations to return Status directly

* Simplify _pluck to always store both location and value

* Use Topology.childBounds directly in type tree validation

* ArrayIterator consolidation

* Rename WithinRatio indices to referencePluckIndex/relativePluckIndex, add Slice test

* Rename ConditionLogic to ConditionEvaluator

* Refactor _compare and _compareSignedInt to take value directly

* Inline _evaluate into _transaction to reduce bytecode size

* Reorder Integrity operator handlers to match if-else dispatch order

* Refactor __input to return bool overflow instead of Result struct

* Fix WithinRatio to pass location to _result instead of 0

* Simplify AbiLocation.size

* Add commentary to _tailLocation

* Use calldataload for header reads in AbiLocation

* Refactor _zipLocations

* Return data.length + 1 so that location + size > data.length even when location is 0.

---------

Co-authored-by: Cristóvão <cristovaoth@users.noreply.github.com>

659 of 712 branches covered (92.56%)

Branch coverage included in aggregate %.

1127 of 1209 relevant lines covered (93.22%)

431.18 hits per line