531
74%

Ran 06 Sep 2016 01:59AM UTC

Jobs 1

Files 85

Run time 5s

Badge

Embed ▾

pending completion

Build # 531

Build Type

Pull #60

travis-ci

Committed by

web-flow

Commit Message

Make friend requests stateless

Messenger is slightly twisty when it comes to sending connection status
callbacks It will very likely need at the very least a partial refactor to
clean it up a bit. Toxcore shouldn't need void *userdata as deep as is
currently does.

(amend 1) Because of the nature of toxcore connection callbacks, I decided to
change this commit from statelessness for connections changes to statelessness
for friend requests. It's simpler this was and doesn't include doing anything
foolish in the time between commits.

group fixup because grayhatter doesn't want to do it

"arguably correct" is not how you write security sensitive code

Clear a compiler warning about types within a function.

Pull Request Pull Request #60: Make friend requests stateless

Run Details

8536 of 11752 relevant lines covered (72.63%)

718934.36 hits per line

Uncovered Existing Lines

Lines	Coverage	File
1	100.0	toxcore/onion.c
1	100.0	toxav/msi.c
1	100.0	toxcore/ping.c
1	100.0	toxcore/group.c
1	100.0	toxav/toxav.c
2	100.0	toxcore/util.c
3	100.0	toxcore/friend_requests.c
3	100.0	toxcore/assoc.c
10	100.0	toxav/audio.c
14	100.0	toxcore/friend_connection.c
38	100.0	toxcore/onion_client.c
86	100.0	toxcore/net_crypto.c
95	100.0	toxcore/TCP_connection.c
141	100.0	toxcore/Messenger.c

Jobs

ID	Job ID	Ran	Files	Coverage
2	531.2 (BUILD=toxcore ENV=linux)	06 Sep 2016 01:59AM UTC	0	72.63	Travis Job 531.2

Source Files on build 531

Detailed source file information is not available for this build.

TokTok / toxcore / 531
74%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 531

TokTok / toxcore / 531 74%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 531

TokTok / toxcore / 531
74%

README BADGES
x