NatLabRockies / SolTrace / 21445319301
88%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 81
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.052% (+0.2%) from 87.837%
21445319301

push

github

web-flow 
95 implement embree runner (#96)

* Initial structure for EmbreeRunner

* Bounding box calculations added to surface and aperture structures

* Add tests for aperture bounding box

* Separate logging from thread manager

* Change embree runner to inherit from native runner

* Fix CI builds

* Add tests for surface bounding box

* Add logger to trace_embree function

* Add EmbreeRunner validation test and another short unit test

* Set virtual flag for reading input files; update embree and native runner validation tests to include virtual stage

* Add unit tests for thread manager

* Move embree initialization to part of runner setup

* Commonize interaction type determination between embree and native runners

* EmbreeRunner multi-threading implementation

* Address copilot comments

* Update CI and coverage work flows to build Embree

* Fix work flow errors

* Change windows build to use downloaded binary

* Attempt to fix windows build

* Fix windows CI hopefully. Maybe.

* Pass along number of threads value to embree; another attempt to fix windows CI

* Fix linux compiler warning; attempt whatever to fix windows ci

* Try again

* Updates to README for Embree install and SolTrace build; disable legacy code build by default

* Change cmake include directories to relative paths in embree runner; explicitly mention adding embree dll path to system path in install instructions

* Remove commented code in embree runner header

1022 of 1268 new or added lines in 23 files covered. (80.6%)

14 existing lines in 7 files now uncovered.

6721 of 7633 relevant lines covered (88.05%)

6768501.73 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
88.1
 1.36% coretrace/simulation_runner/native_runner/thread_manager.cpp
1
95.0
 3.24% coretrace/simulation_runner/native_runner/trace.cpp
2
91.3
 0.0% coretrace/simulation_data/surface.hpp
2
92.17
 -0.29% coretrace/simulation_runner/native_runner/native_runner.cpp
2
96.97
 0.0% coretrace/simulation_runner/native_runner/sun_to_primary_stage.cpp
3
74.19
 0.0% coretrace/simulation_data/aperture.hpp
4
90.0
 coretrace/simulation_runner/embree_runner/embree_runner.cpp
5
58.33
 coretrace/simulation_data/utilities.hpp
6
94.7
 12.23% coretrace/simulation_data/surface.cpp
9
65.38
 coretrace/simulation_runner/native_runner/determine_interaction_type.cpp
14
93.55
 coretrace/simulation_runner/embree_runner/trace_embree.cpp
43
63.56
 coretrace/simulation_runner/embree_runner/embree_helper.cpp
154
69.32
 3.67% coretrace/simulation_data/aperture.cpp

Uncovered Existing Lines

Lines Coverage ∆ File
1
74.19
 0.0% coretrace/simulation_data/aperture.hpp
1
92.17
 -0.29% coretrace/simulation_runner/native_runner/native_runner.cpp
1
0.0
 -100.0% coretrace/simulation_runner/native_runner/sphere_calculator.hpp
1
50.0
 -50.0% coretrace/simulation_runner/native_runner/surface_intersection_calculator.hpp
1
95.0
 3.24% coretrace/simulation_runner/native_runner/trace.cpp
3
69.32
 3.67% coretrace/simulation_data/aperture.cpp
6
93.84
 -2.81% coretrace/simulation_runner/native_runner/native_runner_types.cpp
Jobs
ID Job ID Ran Files Coverage
1 21445319301.1 81
88.05
 GitHub Action Run
Source Files on build 21445319301