stacklok / toolhive / 21435382847

60%

Build Type

push

github

Committed by web-flow

Commit Message

Add registry validation and structured errors (#3479)

* Add registry validation and structured errors

This change introduces comprehensive validation for registry configurations
and structured error types for better error handling and classification.

Changes:
- Add 5-second timeout support to HTTP client builder
- Add registry validation in provider_remote.go (isValidRegistryJSON, registryHasServers)
- Add comprehensive validation tests in provider_test.go
- Introduce structured error types (RegistryError, ErrRegistryTimeout, etc.)
- Add error classification logic (classifyNetworkError)
- Update registry.go to return RegistryError types with proper context
- Update tests to reflect new error handling

This lays the foundation for improved error handling in the registry API
and CLI, enabling proper HTTP status codes (502, 504) based on error type.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* remove incorrect e2e scenario

---------

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>

Run Details

100 of 127 new or added lines in 4 files covered. (78.74%)

16 existing lines in 3 files now uncovered.

38738 of 64105 relevant lines covered (60.43%)

77.88 hits per line