cshum / imagor / 21428550258

92%

push

github

feat: add configurable S3 HTTP client connection pooling (#707)

* feat: add configurable S3 HTTP client connection pooling

Add HTTP client tuning options for AWS S3 to improve performance under
high-throughput workloads. The default Go HTTP client uses
MaxIdleConnsPerHost: 2 which is insufficient for production image
serving.

New configuration options:
- S3_HTTP_MAX_IDLE_CONNS (default: 100)
- S3_HTTP_MAX_IDLE_CONNS_PER_HOST (default: 100)
- S3_HTTP_MAX_CONNS_PER_HOST (default: 0, unlimited)
- S3_HTTP_IDLE_CONN_TIMEOUT (default: 90s)
- S3_HTTP_RESPONSE_HEADER_TIMEOUT (default: 0, no timeout)
- S3_HTTP_DISABLE_KEEP_ALIVES (default: false)

The increased MaxIdleConnsPerHost default (100 vs Go's 2) allows better
connection reuse under concurrent load without requiring configuration.

* refactor: simplify S3 HTTP config to single parameter

Per maintainer feedback - only expose MaxIdleConnsPerHost since
it's the only setting that differs from Go defaults (2 → 100).
Other HTTP transport settings use sensible Go defaults.

27 of 27 new or added lines in 1 file covered. (100.0%)

5455 of 5904 relevant lines covered (92.39%)

1.11 hits per line