bitcoindevkit / bdk / 21424931105

79%

push

github

Merge bitcoindevkit/bdk#2106: deps(bdk_chain)!: bump `miniscript` to `13.0.0`

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/17d003a6e6a4f22983f67523cde0aa4e3f82ba78">17d003a6e deps(bdk_chain)!: bump `miniscript` to `13.0.0` (Leonardo Lima)

Pull request description:

  ### Description

  The PR upgrades `miniscript` to it's latest `v13.0.0`, it's a breaking change so it's only meant to being merged in master, can't be backported to `release/chain-0.23.x`.

  - upgrades `miniscript` version to `13.0.0`.
  - fixes the usage of `psbt.sign` in `example_cli.

  BREAKING_CHANGE: `bdk_chain` does re-exports the `miniscript` API, therefore bumping it's version is considered a breaking change.

  ### Notes to the reviewers

  ### Changelog notice

  ```
  ### Changed
  - deps(bdk_chain): upgrades `miniscript` version to `13.0.0`.
  - chore(example_cli): fixes the usage of `psbt.sign` in `example_cli.
  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

ACKs for top commit:
  evanlinjin:
    ACK 17d003a6e6a4f22983f67523cde0aa4e3f82ba78
  ValuedMammal:
    ACK 17d003a6e6a4f22983f67523cde0aa4e3f82ba78

Tree-SHA512: c9f37d197cbb096a91a3579c6b8980b4e12

378 of 512 branches covered (73.83%)

Branch coverage included in aggregate %.

4254 of 5352 relevant lines covered (79.48%)

3089.36 hits per line