stacklok / toolhive / 21410526608

60%

Build Type

push

github

Committed by web-flow

Commit Message

Add configurable UserInfo field mapping and UserInfo support for authserver's OAuth provider (#3466)

Add configurable UserInfo field mapping and UserInfo support for OAuth2 provider

Enhance UserInfoFieldMapping to support ordered fallback field chains,
enabling compatibility with non-standard OAuth providers like GitHub that
use different claim names (e.g., "id" instead of "sub").

Changes:
- Replace single field names with ordered lists (SubjectFields, NameFields, EmailFields)
- Add ResolveField() helper with support for numeric ID conversion
- Add ResolveSubject/ResolveName/ResolveEmail methods with defaults
- Implement UserInfoProvider interface on BaseOAuth2Provider
- Support additional headers for provider-specific requirements (e.g., GitHub API versioning)
- Add JSON/YAML struct tags for file-based configuration support

Example YAML configuration for GitHub:
```
upstream:
  client_id: "my-app"
  client_secret: "secret"
  redirect_uri: "http://localhost:8080/callback"
  authorization_endpoint: "https://github.com/login/oauth/authorize"
  token_endpoint: "https://github.com/login/oauth/access_token"
  scopes:
    - user:email
  userinfo:
    endpoint_url: "https://api.github.com/user"
    additional_headers:
      X-GitHub-Api-Version: "2022-11-28"
    field_mapping:
      subject_fields: ["id", "login"]
      name_fields: ["name", "login"]
      email_fields: ["email"]
```

Run Details

43 of 43 new or added lines in 2 files covered. (100.0%)

36 existing lines in 4 files now uncovered.

38421 of 63846 relevant lines covered (60.18%)

78.05 hits per line