supabase / auth / 21407255753

69%

push

github

chore: Clean up IP address tracking  (#2341)

## What kind of change does this PR introduce?

This PR cleans up various issues and inconsistencies in IP address
tracking in Auth, including:

* Fixing middleware ordering so request logs respect `Sb-Forwarded-For`
as the canonical IP address source if the user enables it
* Replacing all usage of request `RemoteAddr` values with
`utilities.GetIPAddress` calls

## What is the current behavior?

Request logs do not show the correct IP address when passing the
`Sb-Forwarded-For` header with `SbForwardedForEnabled` set to true.
Similarly, audit logs only show the value of the request's `RemoteAddr`
struct field, which is populated by the `github.com/sebest/xff`
middleware.

## What is the new behavior?

IP address tracking should be consistent across all Auth code paths.

11 of 12 new or added lines in 3 files covered. (91.67%)

14849 of 21577 relevant lines covered (68.82%)

79.56 hits per line