iovisor / ubpf / 21406842187

78%

push

github

Add RFC 9669 JMP32-class JA (opcode 0x06) support (#702)

* Add RFC 9669 JMP32-class JA (opcode 0x06) support

- Added EBPF_OP_JA32 opcode definition in vm/ebpf.h
- Added interpreter support in vm/ubpf_vm.c (pc += imm)
- Added instruction validation in vm/ubpf_instruction_valid.c
- Added JIT support for x86-64 in vm/ubpf_jit_x86_64.c
- Added JIT support for ARM64 in vm/ubpf_jit_arm64.c
- Added validation for JA32 jump bounds checking

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix JA32 handling in validation and ARM64 JIT

- Fixed jump target calculation for JA32 in sub-program validation
- Added JA32 to ends_with_jump check for sub-program validation
- Updated is_ja check in ARM64 JIT to include JA32

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Consolidate JA32 with other jump instructions in validation

- Merged JA32 into the main jump instruction validation case
- Fixed variable declaration scope issue
- Use conditional to select imm vs offset based on opcode

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Final: RFC 9669 JMP32-class JA implementation complete

All checks passed:
- Code review: Minor nitpicks only, no blocking issues
- Security scan: No vulnerabilities detected
- All 14 custom tests passing
- Manual verification of JA32 interpreter and JIT

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Remove accidentally committed _codeql_build_dir build artifacts

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Remove _codeql_detected_source_root and add to .gitignore

This is a CodeQL-generated symlink that should not be tracked in git.

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix signed overflow issues and add ja32 test

- Use int64_t for jump target calculations to avoid signed overflow with large immediates
- Fix sub-program validation to c... (continued)

23 of 28 new or added lines in 3 files covered. (82.14%)

6902 of 8849 relevant lines covered (78.0%)

395426.13 hits per line