stacklok / toolhive / 21403491932

60%

Build Type

push

github

Committed by web-flow

Commit Message

fix: improve stability of remote MCP server connections (#3417)

* fix: improve stability of remote MCP server connections

This PR addresses two issues that cause remote MCP servers (like Datadog
and Glean) to fail after laptop sleep/wake cycles:

1. Port conflicts after unclean shutdown:
   - After laptop sleep, zombie processes may hold ports without releasing them
   - Added SO_REUSEADDR socket option to allow port reuse
   - Applied to both transparent and httpsse proxies

2. Panic from duplicate WriteHeader calls:
   - The telemetry middleware's responseWriter could call WriteHeader twice
   - This causes 'http: superfluous response.WriteHeader' panics
   - Added headerWritten guard to prevent duplicate calls

Tested with Datadog and Glean MCP servers through multiple sleep/wake cycles.

* fix(lint): rename unused parameters to _ in ListenConfig.Control

Signed-off-by: Frederic Le Feurmou <flfeurmou@indeed.com>

* fix(build): extract ListenConfig to platform-specific files for Windows support

Signed-off-by: Frederic Le Feurmou <flfeurmou@indeed.com>

* fix(license): add SPDX headers to new files

Signed-off-by: Frederic Le Feurmou <flfeurmou@indeed.com>

* fix(lint): add package comments

Signed-off-by: Frederic Le Feurmou <flfeurmou@indeed.com>

* adds test coverage and update Write to handle headerWritten flag

* fix formatting

---------

Signed-off-by: Frederic Le Feurmou <flfeurmou@indeed.com>
Co-authored-by: amirejaz <amir@stacklok.com>

Run Details

24 of 26 new or added lines in 4 files covered. (92.31%)

2 existing lines in 1 file now uncovered.

38357 of 63755 relevant lines covered (60.16%)

77.59 hits per line