m-lab / autojoin / 21393185556

72%

Build Type

push

github

Committed by web-flow

Commit Message

refactor: consolidate platform-credentials on token-exchange/store (#90)

Consolidating credential storage under platform-credentials namespace

The autojoin API supports two authentication flows:
  1. Direct API key flow - Client sends API key directly to autojoin for validation
  2. JWT flow - Client obtains JWT from token-exchange service, autojoin validates JWT signature

Previously, these flows used separate Datastore namespaces in different GCP projects:
  - mlab-autojoin / "autojoin" namespace - credentials for direct API key flow
  - mlab-oti / "platform-credentials" namespace - credentials for JWT flow (via token-exchange)

This meant organizations and API keys had to be provisioned in both places.

The consolidation plan:                                                                                                                                                                                                                     
  1. PR #88: Make orgadm tool use token-exchange/store with "platform-credentials" namespace
  2. This PR: Make autojoin service use token-exchange/store with "platform-credentials" namespace
  3. Remove duplicated internal/adminx/datastore.go code

After this, both authentication flows validate credentials against the same "platform-credentials" namespace, providing a single source of truth for organization credentials.

* refactor: consolidate platform-credentials on token-exchange/store

- Use token-exchange/store.AutojoinManager in main service (fixes
  namespace mismatch: was "autojoin", now "platform-credentials")
- Remove duplicated internal/adminx/datastore.go (now uses token-exchange/store)
- Remove dead code: internal/adminx/apikeys.go (unused GCP API Keys system)
- Remove dead code: internal/adminx/keysiface/keys.go

* feat: add credentials-project flag for cross-project Datastore access

Add -credentials-project flag to allow autojoin to read credentials
from a different GCP project (mlab-oti) than wher... (continued)

Run Details

0 of 10 new or added lines in 1 file covered. (0.0%)

9 existing lines in 1 file now uncovered.

1253 of 1736 relevant lines covered (72.18%)

0.8 hits per line