supabase / supavisor / 21359260319

65%

Build Type

push

github

Committed by web-flow

Commit Message

fix: monitor TCP socket and terminate ClientHandler if it closed (#824)

In at least one case, our current handling didn't catch the closed
socket, leading to potential zombie connections. This changes the
approach according to the discussion on #783, instead relying on
monitoring.

The most complex part is the upgrade process: we need to ensure the
existing ClientHandlers are updated to monitor their sockets, but since
some of the sockets were already upgraded to TLS, we only have the
`sslsocket` record. In these cases, we monitor the `connection_handler`
process. For this reason, we must be able to handle both ports and
processes.

In case the change is reverted, no `code_change` is necessary, since the
DOWN message will be caught by the catch all clause.

Run Details

16 of 16 new or added lines in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

1928 of 2945 relevant lines covered (65.47%)

4179.47 hits per line