tarantool / tarantool / 21358869963
88%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 524
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 87.596% (+0.004%) from 87.592%
21358869963

push

github

sergepetrenko 
limbo: introduce explicit state

The txn_limbo::state now is one member which clearly reflects the
state of the limbo: inactive, leader, or replica.

Previously these states also existed but had to be deducted from
other properties.

With the new approach it became possible to remove some of the
other state-flags, simplify others, and simplify the limbo's API
in general.

For example, there is no more such states as "fenced" or "frozen".
Because these were very high-level descriptions of events like
when a leader steps down due to quorum loss or a new term
appearing or when the instance was just restarted. These were
events, not states. The state in these cases is the limbo becoming
a "replica" instead of "leader".

With such approach the concept of "unfencing" also disappears.
Because a replica can't just become a leader even if the quorum
is restored. It anyway needs to be elected again.

The most important parts of this commit are the state itself
and the new flag is_transition_in_progress. The new flag
previously didn't exist explicitly. These new things will be
needed in scope of #8095, where ownership transition will actually
be in progress for quite a while, not only during PROMOTE journal
write.

Part of #8095

NO_DOC=refactoring
NO_CHANGELOG=refactoring
NO_TEST=tested

70226 of 118221 branches covered (59.4%)

71 of 71 new or added lines in 5 files covered. (100.0%)

178 existing lines in 15 files now uncovered.

105585 of 120536 relevant lines covered (87.6%)

1383078.79 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
88.96
 -0.61% src/box/engine.c
1
96.88
 -1.56% src/box/engine.h
1
92.48
 0.0% src/box/vinyl.c
1
90.14
 -0.08% src/box/vy_log.c
1
85.81
 -0.05% src/box/xlog.c
1
97.05
 -0.1% src/lib/msgpuck/msgpuck.h
2
98.07
 0.0% src/box/lua/info.c
2
88.27
 -0.03% src/box/vy_run.c
2
93.79
 -0.03% src/box/xrow_update_field.c
2
81.38
 -0.6% src/lib/core/coio.c
3
22.66
 -0.06% src/lib/uri/uri_parser.c
4
94.15
 -2.13% src/box/vy_range.c
6
95.2
 -1.25% src/box/vy_read_iterator.c
22
94.28
 -0.03% src/box/txn_limbo.c
129
91.03
 0.01% src/box/box.cc
Jobs
ID Job ID Ran Files Coverage
1 21358869963.1 524
87.6
 GitHub Action Run
Source Files on build 21358869963