levibostian / decaf / 21334305043

82%

push

github

fix: deno runtime permission not compatible with current_working_directory feature (#134)

## Related GitHub Issues
<!-- Link to any related GitHub issues that this pull request addresses
or closes. -->

## Problem
<!-- A clear description of the problem that this pull request is
solving. -->

Deploying 0.11.0 with the new current_working_directory feature is
failing. The Deno code that checks if `current_working_directory` is a
valid input needs read permission I guess. Kinda sucks but I get it.

## Solution
<!-- Describe the approach you took to solve the problem and the changes
made in this pull request. -->

I looked into a few different solutions and tried some things out, but
ultimately, I think the solution that offers the best developer
experience is to simply expand the deno runtime permissions to allow
reading of all files.

I don't want to give decaf more permissions than it needs. However, I've
made this decision because:
- decaf already has permission to all environment variables and
executing commands. With this permission, it can do about anything
already, including reading all files.
- I have some ideas for how we can refactor decaf to allow it to require
less permissions. But, that will have to come later. Enable this for now
to unblock us and improve it later.

## Testing
<!-- Choose one of the below options for how you tested the code change.
Include any specific setup or instructions for testing. -->
- [ ] Added automated tests. 
- [ ] Manually tested. If you check this box, provide instructions for
others to test, too.

Running a deployment is the only way to test this unfortunately. 

## Notes for reviewers 
<!-- If there is any additional information you would like to share with
the person reviewing this pull request, please provide it here. -->

219 of 233 branches covered (93.99%)

Branch coverage included in aggregate %.

1294 of 1623 relevant lines covered (79.73%)

72.38 hits per line