babelfish-for-postgresql / babelfish_extensions / 21318344890

77%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

BCP fix done token spanning packet boundaries (#4478) (#4496)

Problem: When DONE token (13 bytes) was split across TDS packet boundaries, only the first byte (0xFD) would be checked, causing the remaining bytes in the next packet to be misinterpreted.
Actually we have always seen that done token gets truncated to fit in available space, I can see in some cases the done token is only 8 bytes at the end of the message - packet marked with EOM. If we're at EOM with incomplete DONE token, that's actually acceptable.

Solution:

Check if DONE token is present
Only fetch additional bytes if NOT at EOM and buffer has < 13 bytes
Accept incomplete DONE tokens at EOM (handles truncated tokens from optimizing clients)

JIRA: BABEL-6317

Co-authored-by: Kushaal Shroff <51415286+KushaalShroff@users.noreply.github.com>

Run Details

4 of 5 new or added lines in 1 file covered. (80.0%)

2 existing lines in 1 file now uncovered.

52479 of 68471 relevant lines covered (76.64%)

387706.62 hits per line