Alan-Jowett / CoPilot-For-Consensus / 21308345625

78%

push

github

Standardize duplicate document handling across all document store adapters (#1016)

* Initial plan

* Add DocumentAlreadyExistsError exception and update handlers

- Add DocumentAlreadyExistsError exception to document_store module
- Update Azure Cosmos DB adapter to raise DocumentAlreadyExistsError instead of generic DocumentStoreError
- Update parsing service to catch DocumentAlreadyExistsError and handle as duplicate
- Add tests for new exception handling in messages and threads

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Update Azure Cosmos DB test to expect DocumentAlreadyExistsError

- Update test_insert_document_resource_exists to expect DocumentAlreadyExistsError
- Import DocumentAlreadyExistsError in test file
- Update test docstring to reflect the new specific exception type

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Update MongoDB adapter to raise DocumentAlreadyExistsError

- Import DocumentAlreadyExistsError in MongoDocumentStore
- Catch pymongo DuplicateKeyError and raise DocumentAlreadyExistsError
- Update docstring to document new exception
- Maintains backward compatibility by handling pymongo not being installed

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Remove redundant duplicate key error fallback logic

- Remove _is_duplicate_key_error helper function (no longer needed)
- Remove fallback handling for raw DuplicateKeyError exceptions
- All duplicate detection now uses standardized DocumentAlreadyExistsError
- Update tests to use DocumentAlreadyExistsError instead of DuplicateKeyError
- Remove pymongo.errors.DuplicateKeyError import from tests

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Refactor MongoDB DuplicateKeyError handling to avoid nested try-catch

- Move pymongo.errors.DuplicateKeyError import to module level with try-except
- Replace nested try-catch in insert_document with simpl... (continued)

27 of 30 new or added lines in 5 files covered. (90.0%)

8591 of 11075 relevant lines covered (77.57%)

0.87 hits per line