Alan-Jowett / CoPilot-For-Consensus / 21306722364

78%

push

github

Fix azure-servicebus AttributeError crash from handler race condition (#1019)

* Initial plan

* Add defensive error handling for azure-servicebus AttributeError

- Add try-except blocks for AttributeError in AutoLockRenewer operations
- Add error handling for receiver operations (complete_message, abandon_message)
- Add logging with full traceback to help diagnose SDK bugs
- Document known azure-servicebus SDK bug (GitHub #35618, #36334)
- Add comprehensive test coverage for AttributeError scenarios

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add comprehensive documentation for azure-servicebus AttributeError fix

- Document root cause analysis with SDK bug references
- Provide detailed impact assessment
- List all code changes with line numbers
- Include monitoring and alerting guidelines
- Add verification steps and recommendations

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix inconsistent AttributeError handling in message completion

- Remove re-raise after successful message processing
- Add warning about message redelivery when completion fails
- Ensure service continues processing despite completion failures
- Maintain consistent graceful degradation throughout

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Improve error handling logic and fix code review feedback

- Separate callback error from receiver AttributeError handling
- Remove duplicate imports in test files
- Ensure callback exceptions are properly re-raised
- Fix linting issues (trailing whitespace, blank lines)
- Improve code clarity with explicit callback_error variable

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add clarifying comments for error handling design decisions

- Explain why AttributeError is not re-raised (graceful degradation)
- Document callback_error pattern rationale
- Clarify separation of callback errors from receiver er... (continued)

36 of 45 new or added lines in 1 file covered. (80.0%)

8585 of 11067 relevant lines covered (77.57%)

0.87 hits per line