stacklok / toolhive / 21293416805

60%

Build Type

push

github

Committed by web-flow

Commit Message

Refactor RBAC management to eliminate code duplication (#3368)

* refactor rbac

Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>

* Refactor RBAC management to eliminate code duplication

Introduce a common EnsureRBACResources method in pkg/kubernetes/rbac
that consolidates the pattern of creating ServiceAccount, Role, and
RoleBinding resources. This eliminates ~170 lines of duplicated code
across controllers.

Co-authored-by: Yolanda Robla <yolanda@stacklok.com>

* add license headers

* increase test coverage

* changes from review

* fix ci

* changes from review

* bump chart version

---------

Signed-off-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
Co-authored-by: Chris Burns <29541485+ChrisJBurns@users.noreply.github.com>
Co-authored-by: taskbot <taskbot@users.noreply.github.com>

Run Details

300 of 310 new or added lines in 7 files covered. (96.77%)

2 existing lines in 1 file now uncovered.

37104 of 61905 relevant lines covered (59.94%)

79.05 hits per line