optimizely / swift-sdk / 21293166650

94%

Build Type

push

github

Committed by web-flow

Commit Message

[FSSDK-12240] fix flaky tests with proper synchronization (#622)

* docs: add comprehensive project documentation in CLAUDE.md

Added CLAUDE.md file to provide context and guidelines for development:

- Project overview and structure
- Getting started guide with platform support and installation
- Coding standards and common patterns (protocol-oriented design, thread safety)
- Complete development workflow from branch creation to PR
- Testing guide with xcodebuild commands and best practices
- Key API usage examples
- Helpful commands for file searching, testing, and git operations

The documentation is organized logically from introduction to reference material
for better developer onboarding and contribution experience.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* docs: remove redundant instructions from CLAUDE.md

Consolidated duplicate sections to improve readability:
- Moved all testing commands to dedicated 'Testing' section
- Kept linting info only in 'Coding Standards'
- Consolidated git commands in 'Helpful Commands'
- Added cross-references in 'Making Changes' workflow
- Removed repeated commands from multiple locations

This reduces redundancy and makes the guide easier to maintain.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* fix: resolve flaky tests and improve test reliability

Fixed multiple test failures and flaky tests across the test suite:

1. **CMAB Test Fixes** (OptimizelyUserContextTests_Decide_CMAB.swift):
   - Fixed testDecideAsync_cmabCacheOptions failing with "Expected 3 calls"
   - Root cause: CMAB cache persisting between tests causing cache hits
   - Solution: Reset cache in setUp/tearDown, use unique userId
   - Added thread-safe state tracking in MockCmabService
   - Added clarifying comments for variation IDs
   - Removed commented-out code

2. **Event Dispatcher Retry Tests** (EventDispatcherRetryTests.swift):
   - Fixed testRetry_AllAttemptsExhausted timing issues
   - Fixed testRetry... (continued)

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

56 existing lines in 21 files now uncovered.

1122 of 1197 relevant lines covered (93.73%)

8852.13 hits per line