safe-global / safe-client-gateway / 21285382388

89%

Build Type

push

github

Committed by web-flow

Commit Message

feature(portfolio): negate debt position fiat value (#2864)

* feature(portfolio): negate debt position fiat value

* fix: remove double negation and add PositionType.loan

* Auto-commit pending changes before rebase - PR/MR synchronize

* Refactor Zerion positions API tests for raw data and schema alignment

Co-authored-by: valentin <valentin@safe.global>

* fix: address PR #2864 review comments

- Update positions controller test: loan fiatBalance from '20' to '-20' to reflect pre-normalized values
- Use type annotation instead of cast for chain in zerion-positions-api.service.spec.ts
- Simplify configurationService cast and add missing ZerionChainMappingService mock
- Change fiatConversion check from truthy to !== null for consistency with fiatBalance

* fix: adapt dust filter to negative values (use absolute)

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: valentin <valentin@safe.global>

Run Details

2957 of 3721 branches covered (79.47%)

Branch coverage included in aggregate %.

17 of 18 new or added lines in 5 files covered. (94.44%)

2 existing lines in 2 files now uncovered.

14005 of 15314 relevant lines covered (91.45%)

589.37 hits per line